[buddypress-trac] [BuddyPress] #3434: $secondary_item_id is no longer optional in delete_for_user_by_item_id

[buddypress-trac at lists.automattic.com]

#3434: $secondary_item_id is no longer optional in delete_for_user_by_item_id
-------------------------+-----------------------------
 Reporter:  enderandrew  |      Owner:
     Type:  defect       |     Status:  new
 Priority:  normal       |  Milestone:  Awaiting Review
Component:  Core         |    Version:  1.5
 Severity:  normal       |   Keywords:
-------------------------+-----------------------------
 As per the comment for this function:

  * @param integer $secondary_item_id (optional) The secondary item id of
 the notifications that we wish to use to delete.

 The function changed from:

 function delete_for_user_by_item_id( $user_id, $item_id, $component_name,
 $component_action, $secondary_item_id = false )

 to

 function delete_for_user_by_item_id( $user_id, $item_id, $component_name,
 $component_action, $secondary_item_id = false )

 So now you can't call this function without passing a fifth parameter,
 which breaks plugins. If this change was intentional, the
 comment/description for the function needs to change.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3434>
BuddyPress <http://buddypress.org/>
BuddyPress