[buddypress-trac] [BuddyPress] #3177: member profile forum screens
buddypress-trac at lists.automattic.com
buddypress-trac at lists.automattic.com
Tue Apr 26 18:37:50 UTC 2011
#3177: member profile forum screens
--------------------------+-----------------
Reporter: DJPaul | Owner:
Type: enhancement | Status: new
Priority: critical | Milestone: 1.3
Component: Theme | Version:
Resolution: | Keywords:
--------------------------+-----------------
Comment (by boonebgorges):
3177-1.patch is a first pass at the Replied To filters (option 1 described
above).
I think it's mostly pretty good - it was more straightforward than I
thought it would be.
The one remaining puzzle is the issue of group privacy. At the moment, the
Replied To query (or the Started query for that matter) does *not* respect
group privacy settings. That means that if I reply to a post in a
private/hidden group, and then leave the group, I'll still be able to see
those items on my Forums pages. (So will others, for that matter.) Of
course, when you click through to the topics, group privacy settings are
enforced.
I'm not sure what the best way is to deal with this. (a) We could just do
what we do on the main Forums directory: show only topics from public
groups. Or, (b) we could show only public groups when !bp_is_my_profile(),
and show all topics to the profile owner. Or, (c) we could do it the
"right" way, and only show a given topic if the viewing user has access to
the group. The last way seems best, but it's probably too big a job for
1.3, because there are some performance questions (it'll require at least
one more join against the group members table). So maybe (b) is a fair
compromise for now?
--
Ticket URL: <https://trac.buddypress.org/ticket/3177#comment:4>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list