[buddypress-trac] [BuddyPress] #2084: Frontpage tabs - show if content is available
buddypress-trac at lists.automattic.com
buddypress-trac at lists.automattic.com
Mon Nov 29 04:05:31 UTC 2010
#2084: Frontpage tabs - show if content is available
--------------------+-------------------------------------------------------
Reporter: Ezd | Owner:
Type: defect | Status: new
Priority: minor | Milestone: 1.3
Component: Core | Version:
Keywords: |
--------------------+-------------------------------------------------------
Changes (by boonebgorges):
* component: => Core
Comment:
I'd like some feedback on the attached 2084-1.patch. In order to get the
mention count I had to write a new database method, and I wrote some other
functions (similar to what exists for groups_total_groups_for_user() ) to
make sure the count could be filtered and cached. The big change I want
feedback on has to do with function names.
bp_total_mention_count_for_user() was being used to get the *unread*
mention count, not the total like the name suggests. So I renamed
bp_total_mention_count_for_user() to bp_new_mention_count_for_user() and
usurped the name. Is this a bad idea? (They're easy to switch back if so.)
--
Ticket URL: <http://trac.buddypress.org/ticket/2084#comment:1>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list