[buddypress-trac] [BuddyPress] #2733: groups_join_group() parameter fixes

[buddypress-trac at lists.automattic.com]

#2733: groups_join_group() parameter fixes
-----------------------+----------------------------------------------------
 Reporter:  r-a-y      |       Owner:     
     Type:  defect     |      Status:  new
 Priority:  normal     |   Milestone:  1.3
Component:  Groups     |     Version:  1.3
 Keywords:  has-patch  |  
-----------------------+----------------------------------------------------
Changes (by DJPaul):

  * version:  1.2.6 => 1.3


Comment:

 Thanks for the patch, r-a-y. I was about to put this into trunk then
 started wondering why $bp->groups->current_group is set here at all. We're
 only using it for the group permalink and name.

 If, on a group page, someone called this function without a different
 group id (i.e. not the current group's ID), we'd end up reassigning
 $bp->groups->current_group and the sky would fall. Instead of re-assigning
 the global, can anyone see any issue with assigning the group object to a
 new local variable and using that in the arguments to
 groups_record_activity()?

 Also bumping to 1.3 as too late for 1.2.7.

-- 
Ticket URL: <http://trac.buddypress.org/ticket/2733#comment:1>
BuddyPress <http://buddypress.org/>
BuddyPress