[buddypress-trac] [BuddyPress] #2234: Put bp_insert_activity_meta in it's own div or span so it's easier to style
buddypress-trac at lists.automattic.com
buddypress-trac at lists.automattic.com
Fri Nov 12 23:05:06 UTC 2010
#2234: Put bp_insert_activity_meta in it's own div or span so it's easier to style
------------------------------------------------+---------------------------
Reporter: 21cdb | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: 1.3
Component: Activity | Version:
Keywords: bp_insert_activity_meta, has_patch |
------------------------------------------------+---------------------------
Comment(by boonebgorges):
I agree that the markup here is not very appealing but I would like some
feedback from other devs before making big markup changes. The markup
looks like this right now:
{{{
<div class="activity-header">
<p>
<a href="http://example.com/members/boone/"
title="boone">boone</a> posted an update: <span class="time-since">
33 minutes ago</span> · <a href="http://example.com/activity/p/17/"
class="view" title="View Thread / Permalink">View</a> · <a
href="http://example.com/activity/delete/17?_wpnonce=b302b9d11d" class
="item-button delete-activity confirm">Delete</a>
</p>
</div>
}}}
I think it should probably look like this:
{{{
<div class="activity-header">
<span class="activity-action"><a
href="http://example.com/members/boone/" title="boone">boone</a> posted an
update:</span>
<span class="activity-meta">
<span class="time-since"> 33 minutes ago</span>
· <a href="http://example.com/activity/p/17/" class="view"
title="View Thread / Permalink">View</a> · <a
href="http://example.com/activity/delete/17?_wpnonce=b302b9d11d" class
="item-button delete-activity confirm">Delete</a>
</span>
</div>
}}}
(spacing exaggerated for effect)
Does this strike others as a logical way to break up the markup?
--
Ticket URL: <http://trac.buddypress.org/ticket/2234#comment:3>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list