[buddypress-trac] [BuddyPress] #2310: There is a serious bug in buddypress 1.2.3 signup validation for username

[buddypress-trac at lists.automattic.com]

#2310: There is a serious bug in buddypress 1.2.3 signup validation for username
------------------------------------------------+---------------------------
 Reporter:  faisalzulfiqar                      |        Owner:          
     Type:  defect                              |       Status:  reopened
 Priority:  critical                            |    Milestone:  1.2.5   
Component:  Core                                |   Resolution:          
 Keywords:  register,mysql error,illegal_names  |  
------------------------------------------------+---------------------------

Comment(by aesqe):

 actually, it seems that this whole system is wrong:

 $one = array(1,2,3,4,7);
 $two = array(2,4,5,8,9);

 $intersect = array_intersect($one, $two);
 $diff      = array_diff($one, $two);

 $result = array_merge($diff, $intersect); // Array ( [0] => 1 [1] => 3 [2]
 => 7 [3] => 2 [4] => 4 )

 in the end, you get the first array again, and the filter does not work.

 i thought the solution was to switch array positions because then, the
 filter worked.

 i might be just mad tired, tho, so i'll review this again in the morning,
 but i think i'm right.

-- 
Ticket URL: <http://trac.buddypress.org/ticket/2310#comment:6>
BuddyPress <http://buddypress.org/>
BuddyPress