[buddypress-trac] [BuddyPress] #2455: bb-config creator should use single quotes for salt strings

[buddypress-trac at lists.automattic.com]

#2455: bb-config creator should use single quotes for salt strings
----------------------------+-----------------------------------------------
 Reporter:  francescolaffi  |       Owner:                        
     Type:  defect          |      Status:  new                   
 Priority:  normal          |   Milestone:  1.2.5                 
Component:  Forums          |    Keywords:  dev-feedback has-patch
----------------------------+-----------------------------------------------
 right now it writes the bb-config file with salts in double quotes, that
 is bad because salts are random strings and can have $ in them, so they
 should not be interpreted

 i.e. from my local testing installation
 {{{
 define('BB_AUTH_SALT', "^Dola{t1!k,RaEnLXq$h[C?b}.)~6YWl
 ]#(d|j+99IZZYhLPmQ:M%UGn_V8-8}@");
 }}}

 and I get a {{{PHP Parse error:  syntax error, unexpected '?', expecting
 ']'}}} because of the {{{$h[C?}}} in the salt

 attached diff fix it in 1.2 branch but the same solution is valid in
 trunk, it only changes change double quotes to single quotes around not to
 be interpreted strings

-- 
Ticket URL: <http://trac.buddypress.org/ticket/2455>
BuddyPress <http://buddypress.org/>
BuddyPress