[buddypress-trac] [BuddyPress] #2447: activity: change strings to constants in a few places

[buddypress-trac at lists.automattic.com]

#2447: activity: change strings to constants in a few places
------------------------------------+---------------------------------------
 Reporter:  aesqe                   |        Owner:          
     Type:  defect                  |       Status:  reopened
 Priority:  normal                  |    Milestone:  1.3     
Component:  Activity                |   Resolution:          
 Keywords:  has-patch dev-feedback  |  
------------------------------------+---------------------------------------
Changes (by cnorris23):

  * keywords:  needs-patch => has-patch dev-feedback


Comment:

 First, it should be said that this effects both the 1.2.x branch, and
 trunk. I know I read somewhere that 1.3 is going to make it easier to
 customize URLs, so I don't know if this means we should just change this
 to a 1.2.5 milestone and wait and see what happens with 1.3, or if we
 should stick with the current milestone of 1.3.

 Now, on to the issue. Turns out this was caused by an issue in
 bp_activity_setup_nav() where the constants, BP_FRIENDS_SLUG and
 BP_GROUPS_SLUG, were passed to the bp_core_new_subnav_item() slug
 parameter, when the expected values for bp_has_activities() to function
 properly are 'friends' and 'groups.' For those with javascript disabled,
 the issue also exists in the members/index.php template of bp-default. The
 following patches fix both issues for both 1.2.x and trunk.

-- 
Ticket URL: <http://trac.buddypress.org/ticket/2447#comment:5>
BuddyPress <http://buddypress.org/>
BuddyPress