[buddypress-trac] [BuddyPress] #2447: activity: change strings to constants in a few places

[buddypress-trac at lists.automattic.com]

#2447: activity: change strings to constants in a few places
-------------------------+--------------------------------------------------
 Reporter:  aesqe        |        Owner:          
     Type:  defect       |       Status:  reopened
 Priority:  normal       |    Milestone:  1.3     
Component:  Activity     |   Resolution:          
 Keywords:  needs-patch  |  
-------------------------+--------------------------------------------------
Changes (by cnorris23):

  * keywords:  constants, defines, strings => needs-patch


Comment:

 @aesqe

 You are right in that there is an issue with activity streams when viewing
 profile pages, whether your own or that of another member. However, your
 proposed solution isn't correct. It works, but the reason it works is the
 actual issue. You are right that $bp->current_component changes, and that
 it takes on the value of the constants, but I never mentioned
 $bp->current_component, nor did I state anything to the contrary. When it
 comes to $bp->current_action, my original assertion stands. This is where
 the problem lies. On profile pages, $bp->current_action is taking on the
 value of a related constant, when it should really be one of the following
 (friends/groups/favorites/mentions). I haven't yet tracked down why this
 is happening since I've run out of time for now. I'll come back later and
 change some of the details of the ticket to better reflect the actual
 problem.

-- 
Ticket URL: <https://trac.buddypress.org/ticket/2447#comment:3>
BuddyPress <http://buddypress.org/>
BuddyPress