[buddypress-trac] [BuddyPress] #1948: bp_core_get_root_domain should use get_home_url for better ssl handling, etc

[buddypress-trac at lists.automattic.com]

#1948: bp_core_get_root_domain should use get_home_url for better ssl handling,
etc
---------------------------------------------+------------------------------
Reporter:  junsuijin                         |       Owner:  junsuijin
    Type:  enhancement                       |      Status:  assigned 
Priority:  major                             |   Milestone:  1.3      
Keywords:  has-patch, tested, needs-testing  |  
---------------------------------------------+------------------------------
Changes (by junsuijin):

  * status:  new => assigned
  * milestone:  1.2.2 => 1.3


Comment:

 I just added a patch that will make this feature backwards compatible.

 CASE 0: It works as is.

 CASE 1: I tested it by commenting out
 {{{ /*if ( function_exists( 'get_home_url' ) )
         return get_home_url( $blog_id, $path, $scheme );*/ }}}
 near the top of bp-core-wpabstraction.php

 CASE 2: Includes changes from CASE 1 in addition to an explicit change in
 bp-core.php such that it reads
 {{{ if ( defined( 'BP_ENABLE_MULTIBLOG' ) )
         $domain = bp_core_get_home_url( 3 );
 else
         $domain = bp_core_get_home_url( 3 ); }}}

 Both test cases produced working and expected results (all urls pointed to
 blogid 3 in CASE 2).

 CASE 3: As an afterthought I reproduced CASE 2, but using a blog id I knew
 to not exist. I have updated the patch to handle such a situation by
 pointing to the appropriate bp_core_get_root_domain() blog.

 This patch could use some more testing on different setups but so far
 seems good.

-- 
Ticket URL: <https://trac.buddypress.org/ticket/1948#comment:3>
BuddyPress <http://buddypress.org/>
BuddyPress