[buddypress-trac] [BuddyPress] #1801: Cannot leave group

[buddypress-trac at lists.automattic.com]

#1801: Cannot leave group
-----------------------------------+----------------------------------------
Reporter:  cnorris23               |       Owner:     
    Type:  defect                  |      Status:  new
Priority:  blocker                 |   Milestone:  1.2
Keywords:  has-patch dev-feedback  |  
-----------------------------------+----------------------------------------
 Leaving a group failed to work. BP_Groups_Member::delete() always returned
 true, so I cast $delete_result as an integer. I also added some feedback
 to let users know they either can't leave the group as the only admin, or
 that they've successfully left the group.

 I did have one question. In the groups leave function there is this line

 {{{
 if ( !groups_uninvite_user( $user_id, $group_id, true ) )
 }}}

 The groups_uninvite_user() function doesn't accept the 'true' parameter.
 However, BP_Groups_Member::delete(), accepts $check_empty parameter, which
 defaults to true. The string $check_empty isn't used anywhere in the
 BP_Groups_Member::delete() function. Are the extra parameters something we
 should lose?

-- 
Ticket URL: <http://trac.buddypress.org/ticket/1801>
BuddyPress <http://buddypress.org/>
BuddyPress