[buddypress-trac] [BuddyPress] #2970: duplicate sql in BP_Activity_Activity::get/get_specific
buddypress-trac at lists.automattic.com
buddypress-trac at lists.automattic.com
Fri Dec 24 19:12:22 UTC 2010
#2970: duplicate sql in BP_Activity_Activity::get/get_specific
----------------------+--------------------
Reporter: DJPaul | Owner: DJPaul
Type: defect | Status: new
Priority: normal | Milestone: 1.3
Component: Activity | Version:
Keywords: |
----------------------+--------------------
BP_Activity_Activity::get and BP_Activity_Activity::get_specific methods
are similar and share a lot of common SQL. get_specific() is used on an
activity's permalink page. What it doesn't do, compared to get(), is fetch
the user's user_fullname. This is an inconsistency and can possibly lead
to a second SQL query.
In trunk, get() allows for activity IDs to be included or excluded from
the results. We can use these new parameters to remove all of the
duplicate functionality from get_specific().
--
Ticket URL: <https://trac.buddypress.org/ticket/2970>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list