[buddypress-trac] [BuddyPress] #2517: [patch] Confirm Password to change Password or Email (dup check) on General Settings

[buddypress-trac at lists.automattic.com]

#2517: [patch] Confirm Password to change Password or Email (dup check) on General
Settings
---------------------+------------------------------------------------------
  Reporter:  nuprn1  |       Owner:                          
      Type:  defect  |      Status:  closed                  
  Priority:  normal  |   Milestone:  1.3                     
 Component:  Core    |     Version:                          
Resolution:  fixed   |    Keywords:  has-patch, needs-testing
---------------------+------------------------------------------------------

Comment(by hnla):

 What is the issue perceived or otherwise with fixing template_title()?

 As Boone will testify due to the lack of correct and proper semantic
 formatting for that tag in the template files he didn't use that function
 in a plugin instead opting to add a heading tag within his
 template_content function, result for all the right reasons is wrong sadly
 as we have merged data layer with presentational layer the frontend coder
 has no means of control of a markup tag that should rightly only exist in
 a template/view file (I can see the argument that says the plugin function
 for content being a view but nonetheless it's in a file that shouldn't be
 modified.

 The template tag does need to wrapped in a semantic element as it's worse
 if it is used and bare naked cdata is output, as Ray mentioned is it not
 simple enough to wrap element and template function in a:
 if(template_title())

 I'll test that and submit a patch if necessary.

-- 
Ticket URL: <http://trac.buddypress.org/ticket/2517#comment:19>
BuddyPress <http://buddypress.org/>
BuddyPress