[buddypress-trac] [BuddyPress] #2566: [patch] “Send Private Message” and “Mention this User” Button Filtering
buddypress-trac at lists.automattic.com
buddypress-trac at lists.automattic.com
Mon Aug 23 08:11:28 UTC 2010
#2566: [patch] “Send Private Message” and “Mention this User” Button Filtering
-----------------------+----------------------------------------------------
Reporter: jeffsayre | Owner: jeffsayre
Type: defect | Status: new
Priority: major | Milestone: 1.2.6
Component: Core | Keywords: has-patch, security, privacy, abstraction, filters
-----------------------+----------------------------------------------------
Comment(by hnla):
Some quick observations from a frontend developers perspective working
these elements. (Apologies for butting in.)
Working in a file such as members-header.php one of the first things that
strikes one and needs dealing with is the markup structure for the item-
buttons structure; as the name suggests 'items' it really should be a list
construct using a series of divs is semantically null. With the present
setup I can easily re-work this which is good!
In an ideal world I would prefer a template function that aggregated any
items actioned to 'Item-buttons' and that further allowed me to pass
parameters to control the markup structure returned (similar to many WP
template functions)
Practically speaking please don't make any changes that involve hardcoded
markup structure in core files unless we can override it by passing
through parameters from the template tag.
--
Ticket URL: <http://trac.buddypress.org/ticket/2566#comment:9>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list