[buddypress-trac] [BuddyPress] #2293: Hidden groups activity shows in friends > activity screen of non group members

[buddypress-trac at lists.automattic.com]

#2293: Hidden groups activity shows in friends > activity screen of non group
members
----------------------+-----------------------------------------------------
 Reporter:  hnla      |       Owner:                          
     Type:  defect    |      Status:  new                     
 Priority:  critical  |   Milestone:  1.3                     
Component:  Core      |    Keywords:  has-patch, needs-testing
----------------------+-----------------------------------------------------

Comment(by boonebgorges):

 hnla - I think I agree with you.

 The fine grained control over activity visibility would be nice, but the
 logic is relatively complicated - it'd take a fair amount of overhead to
 determine dynamically for each activity item (from the group component)
 whether the current user should be able to see it. It'd require a full
 group list, along with a full list of the groups to which the
 loggedin_user belongs, to be called up every time bp_has_activities was
 called.

 I'm attaching a patch that gives a quick, though less than ideal, fix for
 the problem. It filters out all hide_sitewide activity items when you're
 viewing the Friends tab on your activity page.

-- 
Ticket URL: <http://trac.buddypress.org/ticket/2293#comment:8>
BuddyPress <http://buddypress.org/>
BuddyPress