[buddypress-trac] [BuddyPress] #997: New theme structure doesn't work with parent theme not being a BP framework

[buddypress-trac at lists.automattic.com]

#997: New theme structure doesn't work with parent theme not being a BP framework
------------------------+---------------------------------------------------
  Reporter:  Detective  |       Owner:  Detective               
      Type:  defect     |      Status:  assigned                
  Priority:  major      |   Milestone:  1.1                     
Resolution:             |    Keywords:  has-patch, needs-testing
------------------------+---------------------------------------------------
Changes (by Detective):

  * keywords:  needs-patch => has-patch, needs-testing


Comment:

 I don't agree. If you search for "!=" in the BuddyPress code you'll find
 that the prominent string comparison seems to be the opposite of what you
 propose. Even in the same file you can find both ... example:

 bp-xprofile-classes.php
 {{{
 if ( $message != '' ) {
 }}}
 {{{
 if ( '' != $option_value ) {
 }}}
 {{{
 if ( $this->exists() && $this->value != '' ) {
 }}}

 I don't think it's worth to rewrite the patch just because you think it
 lacks code styling consistency.

 I still propose the original patch, since in my setup it works ok (I have
 kept testing my bp framework extensively with the patch applied, always
 comparing with tbe standard bp framework).

-- 
Ticket URL: <http://trac.buddypress.org/ticket/997#comment:10>
BuddyPress <http://buddypress.org/>
BuddyPress