[wp-trac] [WordPress Trac] #61114: PHP 8+ Fatal Error in WP_Upgrader due to TypeError in array_keys() Call

[WordPress Trac]

#61114: PHP 8+ Fatal Error in WP_Upgrader due to TypeError in array_keys() Call
-----------------------------+------------------------------
 Reporter:  verygoode        |       Owner:  (none)
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Upgrade/Install  |     Version:  2.8
 Severity:  normal           |  Resolution:
 Keywords:  needs-patch      |     Focuses:
-----------------------------+------------------------------

Comment (by verygoode):

 With the casting, without a fatal, a warning may also be observed in WP-
 CLI

 `Warning: Directory listing failed. "hello-dolly"`

 The following warning is also logged in some cases, given that other
 events are clearing out the upgrade folder.


 {{{
 [02-May-2024 19:28:03 UTC] PHP Warning:  dir(/Users/test/Local Sites
 /testing-upgrader/app/public/wp-
 content/upgrade/woocommerce.8.8.3-6ZaMui/woocommerce/src/Internal/Admin/Onboarding/):
 Failed to open directory: No such file or directory in /Users/test/Local
 Sites/testing-upgrader/app/public/wp-admin/includes/class-wp-filesystem-
 direct.php on line 636
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/61114#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform