[wp-trac] [WordPress Trac] #43640: Add an audio and video player to the media manager modal

WordPress Trac noreply at wordpress.org
Thu Oct 15 21:04:06 UTC 2020


#43640: Add an audio and video player to the media manager modal
-------------------------------------------------+-------------------------
 Reporter:  johnbillion                          |       Owner:  (none)
     Type:  feature request                      |      Status:  new
 Priority:  normal                               |   Milestone:  5.6
Component:  Media                                |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots needs-     |     Focuses:
  testing needs-refresh                          |
-------------------------------------------------+-------------------------

Comment (by garrett-eclipse):

 From an initial code review I've uploaded
 [https://core.trac.wordpress.org/attachment/ticket/43640/43640.3.diff
 43640.3.diff] that combines the `<# if ( 'video' !== data.type && 'audio'
 !== data.type ) { #>` conditional into the previous statement as an else
 since both these conditions were checked in that chain.

 Note: This doesn't address @johnbillion's flagged items, just wanted to
 improve that conditional after my code review.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43640#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list