[wp-trac] [WordPress Trac] #51379: Add filter to function email_exists()

WordPress Trac noreply at wordpress.org
Wed Oct 14 23:39:58 UTC 2020


#51379: Add filter to function email_exists()
---------------------------------------------+-----------------------------
 Reporter:  apermo                           |       Owner:  SergeyBiryukov
     Type:  feature request                  |      Status:  closed
 Priority:  normal                           |   Milestone:  5.6
Component:  Users                            |     Version:
 Severity:  normal                           |  Resolution:  fixed
 Keywords:  has-patch needs-dev-note commit  |     Focuses:
---------------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:16 garrett-eclipse]:
 > Would you mind following up with the docblock improvement in
 [https://core.trac.wordpress.org/attachment/ticket/51379/51379.5.diff
 51379.5.diff].

 Sure, also noticed this myself after the commit :)

 I don't think the function needs the `@since` note though, as we already
 have it on the filter itself.

 Per the [https://make.wordpress.org/core/handbook/best-practices/inline-
 documentation-standards/php/#since-section-changelogs documentation
 standards], `@since` tags are generally added for significant changes
 like:

 * Adding new arguments or parameters
 * Required arguments becoming optional
 * Changing default/expected behaviors
 * Functions or methods becoming wrappers for new APIs

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51379#comment:17>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list