[wp-trac] [WordPress Trac] #49354: Provide 'Cancel' when editing widget in accessibility mode

[WordPress Trac]

#49354: Provide 'Cancel' when editing widget in accessibility mode
-------------------------------------+-------------------------------------
 Reporter:  garrett-eclipse          |       Owner:  audrasjb
     Type:  defect (bug)             |      Status:  reviewing
 Priority:  normal                   |   Milestone:  Future Release
Component:  Widgets                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch has-           |     Focuses:  ui, accessibility,
  screenshots needs-testing          |  administration
-------------------------------------+-------------------------------------
Changes (by garrett-eclipse):

 * keywords:  needs-patch => has-patch has-screenshots needs-testing


Comment:

 Thanks @afercia I've created an initial patch in
 [https://core.trac.wordpress.org/attachment/ticket/49354/49354.diff
 49354.diff] if you and @audrasjb can test/review maybe we can milestone
 for 5.5.

 Notes on the patch;
 - I followed the convention of the non-accessible widget edit screen and
 used the `button-link` approach.
 - I kept the term Cancel instead of using Done. Done is what the term is
 on the non-accessible widget, personally I feel Cancel there makes more
 sense...
 - I copied the `widget-control-close-wrapper` and `widget-control-close`
 classes but wonder if we should if `widget-control-cancel` is more
 appropriate
 - I didn't change the Cancel button found when adding a widget in the non-
 accessible view to a link, it's left as a button.

 Thoughts?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49354#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform