[wp-trac] [WordPress Trac] #9757: Allow Plugin/Theme updates from a uploaded .zip file.

[WordPress Trac]

#9757: Allow Plugin/Theme updates from a uploaded .zip file.
-------------------------------------------------+-------------------------
 Reporter:  hakre                                |       Owner:  azaozz
     Type:  feature request                      |      Status:  closed
 Priority:  high                                 |   Milestone:  5.5
Component:  Upgrade/Install                      |     Version:  2.8
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  dev-feedback has-patch early needs-  |     Focuses:  ui, ui-
  dev-note commit                                |  copy
-------------------------------------------------+-------------------------

Comment (by afragen):

 Replying to [comment:176 SergeyBiryukov]:
 > Replying to [comment:175 afragen]:
 > > Both of the compatibility functions include a test for the parameter
 as empty. It should be sufficient to simply use the compatibility function
 in the conditional.
 >
 > They do, but omitting the check would cause a notice if the plugin data
 doesn't have the `RequiresPHP` key:
 > {{{
 > $new_plugin_data = array();
 > var_dump( is_php_version_compatible( $new_plugin_data['RequiresPHP'] )
 );
 >
 > Notice: Undefined index: RequiresPHP
 > }}}
 >
 > It might be that the key always exists at that point, but that doesn't
 seem to be the case at a glance, so I think including the `! empty()`
 check is a safer option.

 In that case, wouldn’t it make more sense to use `isset()`?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/9757#comment:177>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform