[wp-trac] [WordPress Trac] #48894: Improve the small user sub window at the right corner on the admin bar a.k.a. the Howdy fly-out

[WordPress Trac]

#48894: Improve the small user sub window at the right corner on the admin bar
a.k.a. the Howdy fly-out
-------------------------------------------------+-------------------------
 Reporter:  ixkaito                              |       Owner:  afercia
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.5
Component:  Toolbar                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots needs-     |     Focuses:  ui,
  refresh                                        |  accessibility
-------------------------------------------------+-------------------------

Comment (by afercia):

 @isabel_brison thanks for the patch! I see a few issues.

 More importantly:
 1. When using the Spacebar, we need to emulate the native behavior: **the
 Spacebar key activates buttons when it is released**. That's why
 [attachment:"48894.3.diff"] was using the `keyup` event instead of
 `keydown`. That part shouldn't be changed.
 2. Emulating a mobile device (do set "Mobile" in the Chrome dev tools) the
 menus don't open any longer. This is the reason why the previous patch
 removed the event listeners when `ontouchstart` is present. See comment:18

 Minor:
 - I see a missing `@param` notation on a function docblock.
 - Running `grunt jshint`, it tells me there are 7 errors in the `admin-
 bar.js` file.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48894#comment:49>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform