[wp-trac] [WordPress Trac] #49231: Plugins admin screens: form fields issue on small screens

[WordPress Trac]

#49231: Plugins admin screens: form fields issue on small screens
---------------------------------------+-----------------------------------
 Reporter:  passoniate                 |       Owner:  audrasjb
     Type:  defect (bug)               |      Status:  accepted
 Priority:  normal                     |   Milestone:  5.4
Component:  Plugins                    |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-patch has-screenshots  |     Focuses:  ui, accessibility,
                                       |  css
---------------------------------------+-----------------------------------
Changes (by afercia):

 * keywords:  has-patch has-screenshots commit => has-patch has-screenshots
 * version:  5.3.2 =>


Comment:

 Looking at [attachment:"49231.1.diff"]
 - setting `display: inline-block` on the label alters the width of the
 inner search input: on the small screens view, the search input is
 intentionally set to have a width of `100%` but now it's not full-width
 any longer because its container is inline-block
 - the fix for the "Select all" checkbox table cell alters the `td`
 elements also on the desktop view
 - both fixes should be applied only for the responsive view at the
 appropriate breakpoint

 [attachment:"49231.782.patch"] seems preferable to me because it changes
 the CSS only in the responsive view but:
 - `.wp-filter .search-form input[type="search"]` is used also in the "Add
 Themes" page where there's now an unnecessary top margin
 - it changes ''all'' the `td` elements in the plugins table including the
 ones with the plugin names thus reducing the horizontal spacing: it should
 target only the "Select all" table cell

 Noting that seems to me both these visual glitches happen since a long
 time, see the attached screenshot taken on WP 5.1.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49231#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform