[wp-trac] [WordPress Trac] #42852: Add new user: new password not generated when reopening Show Password

[WordPress Trac]

#42852: Add new user: new password not generated when reopening Show Password
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  5.5
Component:  Users                                |     Version:  4.7
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-screenshots needs-     |     Focuses:  javascript
  design                                         |
-------------------------------------------------+-------------------------
Changes (by adamsilverstein):

 * milestone:  5.4 => 5.5


Comment:

 Thanks for the patch @bookdude13 - this looks pretty nice, however I feel
 like somehow this lost some of the original intent of "Cancel" which was
 to close the "Show Password" section.  I think a design review would be
 worthwhile given how much changed here.

 I captured a screencast of how this looks after your patch.

 [[Image(https://p10.f2.n0.cdn.getcloudapp.com/items/JruWX0EQ/Screen+Recording+2020-02-21+at+01.59+PM.gif?v=abeb029f5437d86f53935d5a7c62b8f1)]]

 [[BR]]
 ----


 @afercia is the issue you described still happening? When I tried to
 reproduce the field was not cleared when I clicked cancel. If you can
 still reproduce, what browser/version are you using? Screencast:

 [[Image(https://p10.f2.n0.cdn.getcloudapp.com/items/04uKrpWL/Screen+Recording+2020-02-21+at+01.56+PM.gif?v=1509607fed904407ff8404b9072a05c4)]]


 ----

 In the mean time since this needs design review and we are approaching 5.4
 beta 3, I'm punting this to 5.5.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42852#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform