[wp-trac] [WordPress Trac] #46964: ID attribute value are used multiple times in "Custom Field" form

[WordPress Trac]

#46964: ID attribute value are used multiple times in "Custom Field" form
-------------------------------------------------+-------------------------
 Reporter:  jankimoradiya                        |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.4
Component:  Editor                               |     Version:  5.0
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch early      |     Focuses:  ui,
  commit needs-dev-note                          |  accessibility
-------------------------------------------------+-------------------------

Comment (by elliotcondon):

 @joedolson Thanks for the reply.

 While I agree with you that the CSS dependencies are easily handled in
 core, it may be a different story for plugins and themes that use the
 `#poststuff` element for inheriting CSS styling for metaboxes.

 For example, this popular plugin "Popup Maker"
 (https://wordpress.org/plugins/popup-maker/) is using the `<div
 id="poststuff">` element within custom admin pages to inherit WP styling
 for metaboxes.

 Advanced Custom Fields PRO takes a similar approach inheriting
 metabox/layout styles for our Options Page feature. Also, a quick Google
 reveals many threads discussing CSS solutions that involve the
 `#poststuff` element.

 Personally, I'm not aware of any plugins relying on the id `#poststuff`
 for jQuery selectors, but can ask around if that would be helpful,
 although this is not my primary concern.

 Moving CSS selectors away from `id` towards `class` is definitely in the
 best interest of WordPress, but I would like to draw attention to the
 potential compatibility impact this could have on the third-party
 community.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46964#comment:37>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform