[wp-trac] [WordPress Trac] #49423: Build: Create Webpack build configuration for vendor dependencies

WordPress Trac noreply at wordpress.org
Wed Feb 12 21:27:20 UTC 2020


#49423: Build: Create Webpack build configuration for vendor dependencies
------------------------------+------------------------------
 Reporter:  aduth             |       Owner:  (none)
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:  javascript
------------------------------+------------------------------

Comment (by aduth):

 >Note that the problems of #46110 are a bit more nuanced, related to
 upstream issues of the package in question. We probably want to expect
 that dependencies are already transpiled; ideally we would not need to
 incorporate something like Babel as part of this configuration.

 To elaborate on this, specifically in regards to #46110.

 I expect that [attachment:"49423-vendor-webpack.diff"] would fix #46110.

 This is because the entrypoint of `formdata-polyfill` is the minified
 copy:

 https://github.com/jimmywarting/FormData/blob/e52a90ceb2e3424e5e2203760ecaeef21dbc5186/package.json#L5

 The minified copy (but not the original source copy) is ES5-ready:

 https://unpkg.com/browse/formdata-polyfill@3.0.19/formdata.min.js

 Technically this means that both the `.js` and `.min.js` versions
 generated from the build would be minified. I don't see this as strictly
 problematic, in that (a) we're just using the default entrypoint and (b)
 while `main` ''should be'' unminified, this is a problem of the upstream
 package.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/49423#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list