[wp-trac] [WordPress Trac] #48772: Missing post ID as parameter for get_comments_number_text()

[WordPress Trac]

#48772: Missing post ID as parameter for get_comments_number_text()
------------------------------+-----------------------
 Reporter:  Hinjiriyo         |       Owner:  donmhico
     Type:  enhancement       |      Status:  reopened
 Priority:  normal            |   Milestone:  5.4
Component:  Comments          |     Version:  4.0
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+-----------------------

Comment (by peterwilsoncc):

 Replying to [comment:19 SergeyBiryukov]:
 > The existing fourth parameter of `comments_number()` was previously the
 number of comments, deprecated in [5101].
 >
 > While keeping it as is and adding a fifth parameter the safest option, I
 believe it should also be safe to just un-deprecate and repurpose the
 fourth parameter. Given that it's been deprecated for the last 13 years,
 it's highly unlikely that someone is still using it.

 Is it worth switching to an arguments array? Four parameters is workable
 but approaching an unwieldy number, switching to an array could be handy
 going forward.

 Important: this isn't a passive aggressive change request disguised as a
 comment, it's really a question. :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48772#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform