[wp-trac] [WordPress Trac] #42766: Issue in update password From admin side and login ith same password

[WordPress Trac]

#42766: Issue in update password From admin side and login ith same password
-------------------------------------+-------------------------------------
 Reporter:  ronakganatra             |       Owner:  adamsilverstein
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  5.4
Component:  Administration           |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  good-first-bug has-      |     Focuses:  ui, javascript,
  patch has-unit-tests needs-        |  administration, performance
  testing                            |
-------------------------------------+-------------------------------------
Changes (by bookdude13):

 * keywords:  good-first-bug has-patch has-unit-tests => good-first-bug has-
     patch has-unit-tests needs-testing


Comment:

 Passwords with no length still don't allow for updating the profile
 (disabled button), but the issue remains for passwords just made of
 spaces. You can update the password to "   " successfully, but then not
 log in with either "   " or the old password.

 Like @ajensen, after the patch I still see the following:
 - When creating a user with two spaces as a password (and weak checkbox
 checked) I can click Add User, although I get the empty password error
 message which stops me from setting it
 - When updating a user with two spaces as a password (and weak checkbox
 checked) I can click Update Profile and it will appear to be successful.
 However, when logging in I cannot use the two space password. The old
 password (the one before "  ") works to log in.

 Right now I think we need the profile update page to not show a success if
 the password ends up trimmed (and thus not updated). A more descriptive
 error message would be nice as well, since the password technically isn't
 empty for the user.

 Note that I haven't checked out the unit test, since my current Windows
 environment isn't set up for that atm :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42766#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform