[wp-trac] [WordPress Trac] #48850: Plugins Screen: introduce "Automatic updates" column / option

WordPress Trac noreply at wordpress.org
Thu Feb 6 21:10:11 UTC 2020


#48850: Plugins Screen: introduce "Automatic updates" column / option
-------------------------------------+-------------------------------------
 Reporter:  jeherve                  |       Owner:  audrasjb
     Type:  feature request          |      Status:  accepted
 Priority:  normal                   |   Milestone:  5.4
Component:  Plugins                  |     Version:  3.7
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  administration,
  has-screenshots dev-feedback       |  multisite
  needs-dev-note needs-design        |
-------------------------------------+-------------------------------------

Comment (by peterwilsoncc):

 @desrosj I've taken a quick look at [attachment:"48850.12.diff"], here are
 my notes.

 * If `WP_AUTO_UPDATE_PLUGINS === false`, `should_update_to_version()`
 should return early and never hit the filter. This will prevent developers
 overriding the site owner's hard coded choice.
 * For plugins that use semantic versioning and therefore may have breaking
 changes between versions (such as WooCommerce), do we need to modify the
 .org API to return `offer_minor` and `offer_patch` to allow for the plugin
 additional control over how it may be auto updated
 * To prevent `malicious-plugin` from messing what's offerer to  `good-
 honest-plugins`, do we need to use PHP Reflections to limit filters
 running on the the plugin to the plugin itself. This is super complex I
 know but keep in mind the offered file can be changed from wp.org to
 malicious.org via filters. This is perhaps a topic for another time.

 Generally, if `WP_AUTO_UPDATE_PLUGINS === false` and sites using version
 control then the auto-updates UI ought not be displayed.

 Sorry for the lateness of my notes on the ticket. I do agree with the
 comment above that this is probably too late for 5.4, unfortunately given
 everyones hard work. Could it be released as a feature plugin between 5.4
 and 5.5?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/48850#comment:90>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list