[wp-trac] [WordPress Trac] #47195: Switch WP_UnitTest_Factory_For_Blog->create_object() to use wp_insert_site()

WordPress Trac noreply at wordpress.org
Fri May 10 20:32:02 UTC 2019


#47195: Switch WP_UnitTest_Factory_For_Blog->create_object() to use
wp_insert_site()
------------------------------+---------------------
 Reporter:  danielbachhuber   |       Owner:  (none)
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  5.3
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |     Focuses:
------------------------------+---------------------

Comment (by davidbaumwald):

 Replying to [comment:4 jeremyfelt]:
 > Thanks for the patch, @davidbaumwald. I think we may need to do a bit
 more in the `$args` that are passed to `wp_insert_site()`. I haven't
 looked closely yet, but I get 11 failures when running the multisite tests
 after [attachment:"47195.diff"] is applied.

 Thanks for the feedback @jeremyfelt.  I've added to the factory some code
 that's similar in effect to what `wpmu_create_blog` was doing.  This has
 resolved the test failures for me.  Let me know if there are any issues
 remaining with the patch or if you'd like to see a different approach.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47195#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list