[wp-trac] [WordPress Trac] #47186: At least one function in /wp-includes/sodium_compat/src/Core32 times out on 32 bit servers

[WordPress Trac]

#47186: At least one function in /wp-includes/sodium_compat/src/Core32 times out on
32 bit servers
-------------------------------------+-------------------------------------
 Reporter:  lovingboth               |       Owner:
                                     |  paragoninitiativeenterprises
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  5.2.1
Component:  Upgrade/Install          |     Version:  5.2
 Severity:  normal                   |  Resolution:
 Keywords:  needs-testing has-patch  |     Focuses:
  commit                             |
-------------------------------------+-------------------------------------

Comment (by paragoninitiativeenterprises):

 Both patches (47186.patch and 47186-update_sodium_compat_to_v1_9_3.patch)
 solve the problem differently.

 The first skips when the timeout is > 40 seconds, because a reported
 runtime of ~30 seconds was causing timeouts. Looking at this patch in
 isolation, it makes sense to bump it to 60.

 However, the second makes the process ''much'' faster. My benchmarks are
 4-5x faster for Ed25519 verification and 9-10x faster for the test suites,
 although others' mileage will certainly vary.

 With the reported reduction from ~30 seconds to ~7, I think detecting
 timeouts shorter than 30 will be safe going forward. However, if you
 believe 60 to be safer, I have no objections.

 I'll issue a superseding, unified patch containing both changes, as soon
 as I know which direction you want to go with the timeout window.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47186#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform