[wp-trac] [WordPress Trac] #46627: is_new_day uses a weak comparison (was: is_new_day uses a week compare)

WordPress Trac noreply at wordpress.org
Sun Mar 24 17:04:23 UTC 2019


#46627: is_new_day uses a weak comparison
-------------------------------------------------+-------------------------
 Reporter:  pbearne                              |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  low                                  |   Milestone:  Awaiting
                                                 |  Review
Component:  Date/Time                            |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-unit-tests dev-feedback has-     |     Focuses:
  patch                                          |
-------------------------------------------------+-------------------------
Changes (by swissspidy):

 * priority:  normal => low


Old description:

> The is_new_day() function uses != to test I see no reason why we can't
> change this too !==
>
> So I have added a patch to do this and Unit test to check it

New description:

 The `is_new_day()` function uses != to test I see no reason why we can't
 change this too !==

 So I have added a patch to do this and Unit test to check it

--

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46627#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list