[wp-trac] [WordPress Trac] #34233: There is not a body class filter within the customizer.

WordPress Trac noreply at wordpress.org
Wed Dec 11 06:58:49 UTC 2019


#34233: There is not a body class filter within the customizer.
--------------------------+-----------------------------
 Reporter:  scofennell@…  |       Owner:  (none)
     Type:  enhancement   |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Customize     |     Version:  3.4
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+-----------------------------
Changes (by dlh):

 * milestone:  Awaiting Review => Future Release


Comment:

 The patch here needs a couple of adjustments, I think:

 - The new filter needs docs. [https://make.wordpress.org/core/handbook
 /best-practices/inline-documentation-standards/php/#4-hooks-actions-and-
 filters Here are the core standards for documenting filters]; the docs for
 `admin_body_class` would be a good guide too.

 - Also like `admin_body_class`, I would say the core classes like `wp-
 core-ui` should be excluded from the filter.

 - A filter name of `customize_body_class`, rather than `customizer_`,
 might be a little more consistent with actions on the page like
 `customize_controls_init`. Perhaps `customize_controls_body_class` might
 be yet more consistent.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/34233#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list