[wp-trac] [WordPress Trac] #46431: wp_unique_term_slug() doesn't guarantee unique slugs for child terms

[WordPress Trac]

#46431: wp_unique_term_slug() doesn't guarantee unique slugs for child terms
--------------------------------------+---------------------
 Reporter:  saskak                    |       Owner:  (none)
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  5.3
Component:  Taxonomy                  |     Version:  4.3
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+---------------------
Changes (by boonebgorges):

 * keywords:  needs-patch needs-unit-tests => has-patch has-unit-tests
 * milestone:  Awaiting Review => 5.3


Comment:

 Thanks all for the detailed report.

 I've written a test that confirms what @saskak describes above (minus the
 additional complication of `wp_update_term()`), and the test confirms that
 the suggested fix from @yashar_hv works. Could I get another set of eyes
 on [attachment:"46431.diff"] ? @dlh since you dropped by recently? :)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46431#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform