[wp-trac] [WordPress Trac] #45396: Import from JSON button is missing on Manage All Reusable Blocks page

WordPress Trac noreply at wordpress.org
Thu Nov 22 22:46:06 UTC 2018


#45396: Import from JSON button is missing on Manage All Reusable Blocks page
----------------------------------------+-------------------------
 Reporter:  noisysocks                  |       Owner:  noisysocks
     Type:  defect (bug)                |      Status:  reopened
 Priority:  normal                      |   Milestone:  5.0
Component:  Editor                      |     Version:  5.0
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch commit fixed-5.0  |     Focuses:
----------------------------------------+-------------------------

Comment (by noisysocks):

 Replying to [comment:9 swissspidy]:
 > Don't you lose the version number when enqueuing the script that way?
 Why not just set `$scripts->add_data( 'wp-list-reusable-blocks', 'group',
 1 );` in `script-loader.php` instead?
 I wrote the patch the only way I know how—I'm not too familiar with these
 APIs 🙂

 Looking at the source for `wp_enqueue_script`, it seems to me that calling
 `wp_enqueue_script()` with `$src = ''` and `$in_footer = true` will have
 the same effect as setting `$script->add_data( 'wp-list-reusable-blocks',
 'group', 1 );` in `script-loader.php`. Is there something I'm missing?

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45396#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list