[wp-trac] [WordPress Trac] #43458: No placeholder for ico file in list view of Media Library

[WordPress Trac]

#43458: No placeholder for ico file in list view of Media Library
--------------------------------------+------------------------------
 Reporter:  Guido07111975             |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Media                     |     Version:  4.9.4
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:
--------------------------------------+------------------------------
Changes (by remyvv):

 * keywords:  needs-patch good-first-bug => good-first-bug has-patch


Comment:

 I have looked into this issue and figured out this is occurs due too a
 omission of `IMAGETYPE_ICO` in the `$displayable_image_types` inside the
 function `file_is_displayable_image`.
 Because `wp_generate_attachment_metadata` calls this function to check if
 it should generate the metadata for an upload, the metadata is not
 generated for `.ico` files.

 The attached patch fixes this.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/43458#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform