[wp-trac] [WordPress Trac] #43632: Add a musical note symbol to Hello Dolly lyrics

WordPress Trac noreply at wordpress.org
Wed Apr 25 08:18:30 UTC 2018


#43632: Add a musical note symbol to Hello Dolly lyrics
-------------------------------------------------+-------------------------
 Reporter:  SergeyBiryukov                       |       Owner:  (none)
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  4.9.6
Component:  Plugins                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch ui-        |     Focuses:
  feedback                                       |  accessibility
-------------------------------------------------+-------------------------

Comment (by audrasjb):

 Hi @desrosj and thanks for the review,

 In `43632.diff` :
 - Same height for both `#dolly` and "Screen options" button (see
 screenshots)
 - Fix "Hello Dolly" line height to be consistent with Screen options
 buttons
 - Adds media queries for mobile view (see animated screenshot)
 - Adds RTL CSS rule to support RTL languages (padding changes)

 Note: indeed, you can't access Hello Dolly lyrics with TAB navigation on
 voice hover because you simply navigate through links. But I think this is
 nice: we don't need any anchor here.

 Cheers,
 Jb

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/43632#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list