[wp-trac] [WordPress Trac] #37893: Implementation of is_registered_sidebar() doesn't match its documented signature

[WordPress Trac]

#37893: Implementation of is_registered_sidebar() doesn't match its documented
signature
-------------------------------+------------------------------
 Reporter:  mdgl               |       Owner:  welcher
     Type:  defect (bug)       |      Status:  assigned
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Widgets            |     Version:  4.4
 Severity:  normal             |  Resolution:
 Keywords:  needs-patch close  |     Focuses:
-------------------------------+------------------------------
Changes (by mdgl):

 * keywords:  needs-patch => needs-patch close


Comment:

 The point about `wp_registered_sidebars` is that it is not clear whether
 in fact the tests are at fault for assuming how the widget "module" is
 implemented.  For example, since #24878 the tests could now use function
 `is_registered_sidebar` which would insulate them from this implementation
 detail.

 Updating the documentation blocks might be an appropriate fix, but it
 would need to be clear that the use of an `int` in functions
 `dynamic_sidebar` and `is_active_sidebar` is not the same as the use of
 `int` in all the other widget functions.

 Still, not much interest in this, so suggest close.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37893#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform