[wp-trac] [WordPress Trac] #40658: Customize: Do fallback full page refresh when selective refresh partial content contains script

WordPress Trac noreply at wordpress.org
Tue May 16 23:56:25 UTC 2017


#40658: Customize: Do fallback full page refresh when selective refresh partial
content contains script
------------------------------+--------------------------
 Reporter:  westonruter       |       Owner:  westonruter
     Type:  defect (bug)      |      Status:  accepted
 Priority:  normal            |   Milestone:  4.8
Component:  Customize         |     Version:  4.5
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+--------------------------
Changes (by westonruter):

 * keywords:  has-patch => has-patch commit


Comment:

 The above also accounts for the situation when you have an external script
 tag followed by an inline script that attempts to reference a variable in
 the external script. Since external scripts are loaded asynchronously when
 dynamically added to the DOM, the second inline script tag gets evaluated
 before the external script can load, resulting in a JS error. With
 [attachment:40658.2.diff] this is also accounted for because when there is
 such an error thrown during selective refresh, it will do a fallback full
 refresh.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40658#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list