[wp-trac] [WordPress Trac] #40344: WP_REST_Request::set_param() ignores parameter order.

WordPress Trac noreply at wordpress.org
Tue May 16 02:09:33 UTC 2017


#40344: WP_REST_Request::set_param() ignores parameter order.
--------------------------------------+-----------------------
 Reporter:  TimothyBlynJacobs         |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  4.8
Component:  REST API                  |     Version:  4.4
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  rest-api
--------------------------------------+-----------------------

Comment (by rmccue):

 Good catch! I didn't get to this previously, but good to go for 4.8,
 because it's a bugfix.

 Patch looks good, but I'd rather avoid using `reset()`, since it modifies
 the array. We know `$order` is an indexed array, so `$first = $order[0]`
 is fine.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40344#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list