[wp-trac] [WordPress Trac] #40702: Add WordCamps and meetup events to the News Dashboard widget

WordPress Trac noreply at wordpress.org
Thu May 11 07:32:44 UTC 2017


#40702: Add WordCamps and meetup events to the News Dashboard widget
-------------------------------------------------+-------------------------
 Reporter:  iandunn                              |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  normal                               |   Milestone:  4.8
Component:  Administration                       |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  needs-dev-note has-patch needs-      |     Focuses:
  unit-tests dev-feedback                        |  javascript, rest-api
-------------------------------------------------+-------------------------

Comment (by flixos90):

 Thanks for the quick response @azaozz!

 I agree that viewing another user's data doesn't make sense with the IP
 detection, so that part could be removed/adjusted.

 Regarding the item schema, I don't think it's a problem. If the .org API
 ever changed, we would need to modify the core code anyway, so we could as
 well adjust the schema.

 And about the amount of code, I get your concern to some extent, but I
 don't think that solution is worse just because it is heavier. It defines
 proper structures for location and event resources (in comparison to the
 AJAX callback just returning "anything we don't know about"). Also most of
 the code isn't actual code, but schema and param definition.

 To summarize my thoughts, just because something is simple functionality
 doesn't mean we shouldn't leverage a proper REST API structure for it. In
 addition it would finally be an admin component using the REST API. :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40702#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list