[wp-trac] [WordPress Trac] #40702: Add WordCamps and meetup events to the News Dashboard widget

WordPress Trac noreply at wordpress.org
Tue May 9 22:36:54 UTC 2017


#40702: Add WordCamps and meetup events to the News Dashboard widget
--------------------------------------+-----------------------------------
 Reporter:  iandunn                   |       Owner:
     Type:  enhancement               |      Status:  new
 Priority:  normal                    |   Milestone:  4.8
Component:  Administration            |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  javascript, rest-api
--------------------------------------+-----------------------------------

Comment (by ocean90):

 Some feedback for [attachment:40702.3.diff]:

 * There should be no need to have `.rtl` classes in `dashboard.css`. The
 build task generates a `dashboard-rtl.css` file automatically.
 * It seems like `inet_ntop()` isn't available on PHP < 5.3 on Windows
 platforms.
 * A few cases of `esc_html_e()` should be replaced with `_e()`.
 * HTML around placeholders like `<strong>%s</strong>` should be moved into
 the argument.
 * DocBlocks should use third-person singular verbs, see
 https://make.wordpress.org/core/handbook/best-practices/inline-
 documentation-standards/php/#language
 * `get_community_events_script_data()` should get the `wp_` prefix.
 * Let's not introduce `wp_get_nearby_events()`, you could check the global
 `$wp_version` instead.
 * `There aren\'t any events scheduled near %s at the moment. Would you
 like to <a href="https://make.wordpress.org/community/handbook/meetup-
 organizer/welcome/">organize one</a>?`: `aren\'t` should  be
 `are’t`, the URL should be a separate string and the placeholder
 needs a translator comment.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40702#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list