[wp-trac] [WordPress Trac] #23197: wp-activate.php, without explanation, does not load site plugins

WordPress Trac noreply at wordpress.org
Fri Mar 31 15:26:55 UTC 2017


#23197: wp-activate.php, without explanation, does not load site plugins
---------------------------------------+-----------------------------
 Reporter:  radiok                     |       Owner:
     Type:  defect (bug)               |      Status:  reopened
 Priority:  normal                     |   Milestone:  Future Release
Component:  Login and Registration     |     Version:  3.0
 Severity:  normal                     |  Resolution:
 Keywords:  needs-testing needs-patch  |     Focuses:  multisite
---------------------------------------+-----------------------------

Comment (by afercia):

 I've just experienced how trying to customise `wp-signup.php` and `wp-
 activate.php` is far from ideal :) I understand removing `WP_INSTALLING`
 is not going to happen soon, but maybe worth considering some improvements
 to make the customisation process less time consuming and more
 straightforward.

 A few things noticed that could be improved:
 - different actions that fire in different places, for example `do_action(
 'signup_header' )` and `do_action( 'activate_header' )` have a similar
 name but they fire at a different time, very confusing at first; not sure
 this can be solved
 - wp-activate would need some more hooks for parity with wp-signup, for
 example it misses a couple hooks around the content which wp-signup does
 have
 - buttons have a very unique styling, pretty inconsistent with the default
 WP styles. They don't use the `.button` CSS class so loading the
 `.buttons.css` stylesheet won-t have any effect; the body element also
 would need a `wp-core-ui` CSS class
 - I'm not sure to understand why `wpmu_signup_stylesheet()` and
 `wpmu_activate_stylesheet()` output inline styles, maybe it's just for
 historical reasons; ideally, deprecate them or move the styles to
 `login.css`
 - wp-activate fails to output a proper document `<title>` tag, not sure
 this can be solved

--
Ticket URL: <https://core.trac.wordpress.org/ticket/23197#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list