[wp-trac] [WordPress Trac] #40010: Regression for #36749. Uploading an image into site_icon breaks customizer

[WordPress Trac]

#40010: Regression for #36749. Uploading an image into site_icon breaks customizer
--------------------------+------------------------------
 Reporter:  aussieguy123  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------------------

Comment (by trepmal):

 I can't tell if there's a reason the template uses
 `data.attachment.sizes.full.url` instead of `data.attachment.url`. Looking
 at https://core.trac.wordpress.org/browser/trunk/src/wp-
 includes/media.php#L3192, it appears that both will have the same value in
 this context.

 I like attachment:40010.1.diff for the fallback, or even just using
 `data.attachment.url` in the first place.

 Since it's trivial to remove the full-size, it would be nice if the
 assumption of its presence wasn't made.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40010#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform