[wp-trac] [WordPress Trac] #21760: get_term_by() calls are not cached

[WordPress Trac]

#21760: get_term_by() calls are not cached
--------------------------------------+--------------------------
 Reporter:  wonderboymusic            |       Owner:  ocean90
     Type:  enhancement               |      Status:  closed
 Priority:  normal                    |   Milestone:  4.8
Component:  Taxonomy                  |     Version:  2.3
 Severity:  major                     |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests  |     Focuses:  performance
--------------------------------------+--------------------------
Changes (by boonebgorges):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [changeset:"40293"]:
 {{{
 #!CommitTicketReference repository="" revision="40293"
 Improve querying for terms with falsey names and slugs.

 Prior to [38677], `get_term_by()` would always return false if
 an empty string were passed as the queried 'name' or 'slug'. The
 refactor to use `get_terms()` broke this behavior; inappropriately
 imprecise `empty()` checks caused the 'name' or 'slug' clause to be
 discarded altogether when fetching terms, resulting in an incorrect
 term being returned from the function.

 We fix the regression by special-casing truly empty values passed
 to `get_term_by()`, and ensuring that `WP_Term_Query` is properly
 able to handle `0` and `'0'` term queries.

 Props sstoqnov.
 Fixes #21760.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/21760#comment:128>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform