[wp-trac] [WordPress Trac] #40113: Change User Roles on Multisite

[WordPress Trac]

#40113: Change User Roles on Multisite
-------------------------------------+------------------------------
 Reporter:  eangulus                 |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Users                    |     Version:  4.7.3
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  multisite
-------------------------------------+------------------------------
Changes (by desrosj):

 * keywords:  needs-patch => has-patch needs-testing


Comment:

 The attached patch copies the logic in `wp-admin/users.php` for
 consistency.

 The current logic will always respect the second dropdown field, though. I
 can see some scenarios where this would create undesired changes.

 Say a person is at the bottom of the page and selects a role. Then they
 scroll up selecting users, and then select a different role in the
 dropdown at the top. The bottom dropdown value would be applied to all
 selected users. This could be very bad, and a huge pain if a large number
 of users had been selected.

 To reproduce, select a role in the dropdown at the top of the table, and
 then select a different role in the bottom dropdown. Click change in
 either row, and the second dropdown is the value respected.

 Some potential solutions to solve this.
 - Use JavaScript to always have the values of these fields match (change
 one, change the other).
 - Always respect the first dropdown. It seems that Bulk Edit currently
 uses this logic.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40113#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform