[wp-trac] [WordPress Trac] #41423: needs documents improvement
WordPress Trac
noreply at wordpress.org
Mon Jul 24 18:52:32 UTC 2017
#41423: needs documents improvement
--------------------------+-----------------------------
Reporter: upadalavipul | Owner: SergeyBiryukov
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 4.9
Component: Media | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch | Focuses: docs
--------------------------+-----------------------------
Comment (by markoheijnen):
As I assumed when I was thinking about it. `load()` was a true protected
method a couple of weeks before the release of WordPress 3.5. Change
[22817] changed the behavior. So it's true that the intent was to always
be like a protected method.
However lately we started adding additional functionality into
`WP_Image_Editor` that people could and already do call `WP_Image_Editor`
themselves. Specially when they only want `WP_Image_Editor_Imagick`. Like
with the PDF thumbnails changing the resolution(would require extending),
some values need to be set before `load()` is being called. If we want to
prevent people from doing this, we should add a settings variable or alike
to `wp_get_image_editor()`.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/41423#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list