[wp-trac] [WordPress Trac] #40188: Filter button should not appear when no comments are available in list

[WordPress Trac]

#40188: Filter button should not appear when no comments are available in list
--------------------------------------+---------------------------------
 Reporter:  swissspidy                |       Owner:  Jim_Panse
     Type:  defect (bug)              |      Status:  assigned
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Comments                  |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  good-first-bug has-patch  |     Focuses:  ui, administration
--------------------------------------+---------------------------------
Changes (by dinhtungdu):

 * keywords:  good-first-bug needs-patch => good-first-bug has-patch


Comment:

 I think we really encounter the problem with Comment type ( Comment and
 Ping) as @swissspidy said before
 > Please note that it also hides the filter button after applying a
 filter. For example, when I have 1 regular comment on my blog and I change
 the filter from "All comment types" to "Pings", the filter button now is
 hidden and I can't change the filter again.
 Why a user need to see a "Ping" option when there isn't any pingback or
 trackback. We should check the number of comment or ping before display
 the filter option for it respectively.
 From here, we can hide the `extra_tablenav` which contains Filter dropdown
 when there isn't any item.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/40188#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform