[wp-trac] [WordPress Trac] #32417: Add new core media widget

WordPress Trac noreply at wordpress.org
Fri Feb 24 02:31:43 UTC 2017


#32417: Add new core media widget
-------------------------------------------------+-------------------------
 Reporter:  melchoyce                            |       Owner:  melchoyce
     Type:  feature request                      |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.8
Component:  Widgets                              |     Version:  4.3
 Severity:  normal                               |  Resolution:
 Keywords:  needs-unit-tests has-patch needs-    |     Focuses:  ui,
  refresh                                        |  administration
-------------------------------------------------+-------------------------

Comment (by gonom9):

 Replying to [comment:122 westonruter]:
 > @gonom9 Is this the right approach? Is this not resulting in the title
 and caption being duplicated in the widget vs. what is stored in the
 attachment? To eliminate that duplication I reverted
 [https://github.com/xwp/wordpress-
 develop/pull/215/commits/0bb0f579d1a5ec686624981b9a1fc9ce12307eea that
 commit] and added a [https://github.com/xwp/wordpress-
 develop/pull/215/commits/dd038c5238a2f4e358222a6ac9d8e2a360cde8b7 new one]
 which takes a different approach to explicitly refresh the widget partial
 in the preview whenever the form is re-rendered.
 No, your approach is much better than mine. I just learned the API for
 refreshing partials. Thanks. :)
 But the latest version was still ignoring the changes in the attachment so
 I made [https://github.com/xwp/wordpress-
 develop/pull/215/commits/0c25774199bb06988bdfba762fd58d9184b9d230 another
 commit]. Also, I think `wp.customize.Widgets` should be
 `wp.customize.previewer` in [https://github.com/xwp/wordpress-
 develop/pull/215/commits/dd038c5238a2f4e358222a6ac9d8e2a360cde8b7#diff-
 20f11d2e79e8e8e587fd0591b9e49365R169 the previous commit].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32417#comment:123>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list