[wp-trac] [WordPress Trac] #20899: is_home() should be able to be true when is_feed()

WordPress Trac noreply at wordpress.org
Wed Feb 22 18:58:08 UTC 2017


#20899: is_home() should be able to be true when is_feed()
-------------------------------------------------+-------------------------
 Reporter:  nacin                                |       Owner:
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  Future
Component:  Query                                |  Release
 Severity:  normal                               |     Version:
 Keywords:  has-patch needs-testing has-unit-    |  Resolution:
  tests dev-feedback                             |     Focuses:
-------------------------------------------------+-------------------------

Comment (by stevenkword):

 [attachment:20899.4.diff] builds upon a patch created in #39157 as an
 attempt to solve this problem by adding two new getter methods and
 modifying the wp_query conditionals.  This allows for the ability to
 distinguish between a home page and a home feed as well as between a
 custom feed and a regular feed.  This solution should protect against the
 regression mentioned by @danielbachhuber and @swissspidy above.  Unit test
 pass as of 4.7.2.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/20899#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list